Comments on: Google Groups KillFile 3.4.4 Released

By: Damian

Damian — Thu, 08 May 2008 02:17:26 +0000

Thanks so much Tim :) I've gone ahead and updated the killfile here and released it as 3.5. I'll close comments in thread so please post any bugs or comments to the Google Groups KillFile 3.5 thread

By: Tim

Tim — Wed, 07 May 2008 23:10:53 +0000

Just a warning for anyone who trys to install from the above address (sorry, I didn’t expect this to appear because my last post with the link in it didn’t) – you will find that your existing expressions disappear. This is because the data is stored based on the url. You’ll be able to copy from one to the other in about:config.

Tim.

By: Tim

Tim — Wed, 07 May 2008 23:08:10 +0000

Fixed another bug – the script breaks if the pattern contains ‘ (single quote) when you try to reanimate.

I’ve also added “Add Address” and “Add Topic” options to the killfile and made the killfile update automatically after pressing ‘X’, ‘Y’, ‘Z’

Hope you like it.

http://www.penney.org/googleGroups.user.js

By: Tim

Tim — Tue, 06 May 2008 21:39:44 +0000

I’ve now done a bit more testing and cleaning up and it all looks like it is working now.

Same URL as before (I’m assuming that my previous comment hasn’t been published because it’s awaiting moderation so I wont’ put the URL in again.)

Tim.

By: Damian

Damian — Tue, 06 May 2008 14:44:13 +0000

I’d only just scanned the comment previously but I see now. The X-Y-Z sounds like a good idea. Thanks for taking the time to poke around.

By: Tim

Tim — Tue, 06 May 2008 14:02:04 +0000

Thanks. I’ve just tested my suggestion above and it seems to work.

But I’m not so bothered about going and editing the data in about:config. I was suggesting it to the OP for him specifically.

Also I’m not sure whether it will confuse most users. Unless you understand about regular expressions and escaping you’re likely to incorrectly edit it.

I’m not sure what might happen if the regular expression isn’t valid – e.g. ‘[a-\]‘ sort of thing.

What would be really sweet is if the manageKillfile option had the ability to edit the expressions as well as reanimate the dead. And that editor could then allow regular expressions.

“Click X to reanimate the dead”
“Click Y to edit the filter”
“Click Z to edit regular expressions (experts only)”

When I’ve got a bit of time I’ll have a play and see what can be done.

Tim.

By: Damian

Damian — Tue, 06 May 2008 12:59:56 +0000

Hi Tim, thanks for finding that, I’ve gone ahead and updated the script. I’ll check out your other suggestion when I get a little free time :)

By: Tim

Tim — Tue, 06 May 2008 09:14:34 +0000

Found another bug:

This line:
GM_log(“>>>>>>>>>>> ” + rowNodes.snapshotItem(u).textContent);

Should be:
GM_log(“>>>>>>>>>>> ” + rowNodes.snapshotItem(0).textContent);

u is undefined at this point. The first time through the loop it works because u gets the value 0. But despite this only being a trace statement, the function aborts at this line with “shapshotItem has no properties” (or something like that) probably because u is greater than number of snapshotItems.

Tim.

By: Tim

Tim — Mon, 28 Apr 2008 09:21:00 +0000

Hmm. I missed a line there:

killspec = RegExpEscape(killspec);
killspec = prompt(”Add to KillFile”, killspec);
data = unescape(GM_getValue(“GoogleKillFile”, “—–”));
list = data.split(splitCh);
list.push(killspec);

Still untested though!

Tim.

By: Tim

Tim — Mon, 28 Apr 2008 08:08:52 +0000

Probably the simplest fix for this would be to change the code so that the dialog that pops up has the ‘\’ escapes. Just clicking OK would then leave it as before but you can then manually modify if you wish.

However, this might confuse people who don’t understand about escaping.

Untested. But probably just change this bit:

killspec = prompt(“Add to KillFile”, killspec);
data = unescape(GM_getValue(“GoogleKillFile”, “—–”));
list = data.split(splitCh);
list.push(RegExpEscape(killspec));

To:

killspec = RegExpEscape(killspec);
data = unescape(GM_getValue(“GoogleKillFile”, “—–”));
list = data.split(splitCh);
list.push(killspec);

Tim.