penney dot org

Running Greasemonkey 0.7.20080121.0
Killfile 3.4.4

When I select a user or topic to kill, the script seems to add ‘\’ characters. To correct these I need to use about:config and manually remove ‘%5C’ from the code before it will work.
The characters are added whenever I manually change a kill file option to use a wildcard (*)

Also, can anyone let me know if it’s possible to use topic kill files such as ‘*wholesale*’. ie: Hide anything with a topic in which the word wholesale appears.
I have the %5C issues with this (as mentioned above) but can’t seem to get this working no matter what I do.

Thanks for any advice. And, as always, thanks for the Killfile. Even with these few minor bugs, it’s a fantastic application.

Probably the simplest fix for this would be to change the code so that the dialog that pops up has the ‘\’ escapes. Just clicking OK would then leave it as before but you can then manually modify if you wish.

However, this might confuse people who don’t understand about escaping.

Untested. But probably just change this bit:

killspec = prompt(”Add to KillFile”, killspec);
data = unescape(GM_getValue(”GoogleKillFile”, “—–”));
list = data.split(splitCh);
list.push(RegExpEscape(killspec));

To:

killspec = RegExpEscape(killspec);
data = unescape(GM_getValue(”GoogleKillFile”, “—–”));
list = data.split(splitCh);
list.push(killspec);

Tim.

Hmm. I missed a line there:

killspec = RegExpEscape(killspec);
killspec = prompt(”Add to KillFile”, killspec);
data = unescape(GM_getValue(”GoogleKillFile”, “—–”));
list = data.split(splitCh);
list.push(killspec);

Still untested though!

Tim.

Found another bug:

This line:
GM_log(”>>>>>>>>>>> ” + rowNodes.snapshotItem(u).textContent);

Should be:
GM_log(”>>>>>>>>>>> ” + rowNodes.snapshotItem(0).textContent);

u is undefined at this point. The first time through the loop it works because u gets the value 0. But despite this only being a trace statement, the function aborts at this line with “shapshotItem has no properties” (or something like that) probably because u is greater than number of snapshotItems.

Tim.

I’ve now done a bit more testing and cleaning up and it all looks like it is working now.

Same URL as before (I’m assuming that my previous comment hasn’t been published because it’s awaiting moderation so I wont’ put the URL in again.)

Tim.

Fixed another bug - the script breaks if the pattern contains ‘ (single quote) when you try to reanimate.

I’ve also added “Add Address” and “Add Topic” options to the killfile and made the killfile update automatically after pressing ‘X’, ‘Y’, ‘Z’

Hope you like it.

http://www.penney.org/googleGroups.user.js

Just a warning for anyone who trys to install from the above address (sorry, I didn’t expect this to appear because my last post with the link in it didn’t) - you will find that your existing expressions disappear. This is because the data is stored based on the url. You’ll be able to copy from one to the other in about:config.

Tim.