For a while I was hacking my regexs so that there was never more than one matching but it was getting impossible to maintain and when it was a new post that broke it rather than a new regex it was hard to track down what needed fixing.

IIRC this was easy to reproduce, just kill the author and the thread of the same post.

I think the problem was lines like this one:
parentTable.removeChild(parentRow);
that would get called multiple times for the same candidate.

But it was a bit of a guess. I don’t know javascript or, in particular, what document.evaluate() actually does. I’m a C and C++ programmer really.

Tim.

Something has gone wrong with the HTML formatting of that code patch.

Hopefully it’s obvious that I’ve simply added ‘!blocked &&’ to the for() loops and moved the initialization of blocked and not done anything really weird like j=0 in the condition of the loop.

Tim.

I’ve made the following changes that seem to fix it for me:

— googlegroupskillfile.user.js.orig 2008-03-19 12:45:16.791559000 +0000
+++ googlegroupskillfile.user.js 2008-03-19 12:45:16.081662000 +0000
@@ -179,8 +179,7 @@
var user = cand.textContent;
var blocked = false;

- for (var j=0; j<list.length; j++) {
- blocked = false;
+ for (var j=0; !blocked && j<list.length; j++) {

topicRE.compile(”^” + list[j]);
if (topicRE.test(topic) || topicRE.test(user)) {
@@ -275,9 +274,9 @@
for (var i=0; i<candidates.snapshotLength; i++) {
var cand = candidates.snapshotItem(i);
var user = cand.textContent;
+ blocked=false;

- for (var j=0; j<list.length; j++) {
- blocked = false;
+ for (var j=0; !blocked && j= 0) {
wrappingTable = document.evaluate(”ancestor::table[2]“, cand, null, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null);

Tim.

p.s. I’ve tried to post this several times before but it always seems to fail.

I have edited the usernames to make them work, so posting the entire list won’t be useful. It no longer kills the thread from the killed user, and the title alone can be the most annoying part, especially with the recent increase in spam as subject. Here are some recently added/unedited names from the end of the variable, and some topics that don’t work:

%FFlandrywhiteh%5C.%5C.%5C.@fdt%5C.net
%FFnflstor%5C.%5C.%5C.@yahoo%5C.com%5C.cn
%FFsales%5C.%5C.%5C.@aaa-replica-watch%5C.com

I have manually added topics based on some of the comments on this website, and might be doing it incorrectly.

%FFTopic%3A%20*nike*
%FFTopic%3AM%60I%205.*
%FFTopic%3AM%27I-5.*
%FFTopic%3AM%2CI.5.*
%FFTopic%3AM-I%205.*
%FFTopic%3AM.I%2C5.*
%FFTopic%3AM%20I.5.*
%FFTopic%3AN95%20*
%FFTopic%3AWholesale*%20

Should topics have an “x” next to them? Mine don’t. It would be great if there was an “x” next to the subject/thread.

(It would be useful to have a tool to create filters, a popup that alows you to enter terms. For example, any of the words: Handbag, hand bag, sneakers, [w]holesale, etc.)

Thanks for all of your time on this, Damian.